 |
 |
For example Fedora 26 should come with GCC 7.1 and mass rebuild is expected next month. xrootd is still at 4.5 for Fedora 26 thus it still will need a fix downstream. Same for CMSSW (at least for now). Btw, is there ETA for 4.6? david > On 16 Jan 2017, at 18:33, Andrew Hanushevsky <[log in to unmask]> wrote: > > Yes, we did so on purpose. The old client is no longer supported and we no > longer fix it. Starting with 4.6 it will also no longer be compiled so you > wouldn'tsee that message. At 5.0 it will be completely removed. > > Andy > > On Mon, 16 Jan 2017, davidlt wrote: > > > You missed the following: > > ``` > > src/XrdClient/XrdClient.cc: In member function 'virtual bool XrdClient::OpenFileWhenRedirected(char*, bool&)': > > src/XrdClient/XrdClient.cc:1375:14: error: enum constant in boolean context [-Werror=int-in-bool-context] > > options &= !kXR_delete; > > ^~~~~~~~~~ > > src/XrdClient/XrdClient.cc:1383:14: error: enum constant in boolean context [-Werror=int-in-bool-context] > > options &= !kXR_new; > > ^~~~~~~ > > ``` > > You are using boolean operation where you needed a bitwise operation. > > > > ``` > > src/XrdCl/XrdClZipArchiveReader.cc: In destructor 'XrdCl::ZipArchiveReaderImpl::~ZipArchiveReaderImpl()': > > src/XrdCl/XrdClZipArchiveReader.cc:246:23: error: ignoring return value of 'XrdCl::XRootDStatus XrdCl::File::Close(uint16_t)', declared with attribute warn_unused_result [-Werror=unused-result] > > pArchive.Close(); > > ^ > > In file included from src/XrdCl/XrdClZipArchiveReader.cc:27:0: > > src/XrdCl/XrdClFile.hh:121:20: note: declared here > > XRootDStatus Close( uint16_t timeout = 0 ) XRD_WARN_UNUSED_RESULT; > > ^~~~~ > > ``` > > > > I am not fully sure how to properly handle this inside `~ZipArchiveReaderImpl()`. I know, that only saving return value (but not using it) already removed the error, but is not a right solution probably. Maybe dtor should be marked as `noexcept(false)` and should throw an exception/terminate. > > > > Will check further. Now it compiles up to 71%. > > > > -- > > You are receiving this because you commented. > > Reply to this email directly or view it on GitHub: > > https://github.com/xrootd/xrootd/pull/448#issuecomment-272914148 > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/xrootd/xrootd/pull/448#issuecomment-272922305>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMB47TEOLDAPP3jHrUFUfPFgUR5Feg_ks5rS6n2gaJpZM4Li0Tn>. > -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/448#issuecomment-272932629 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1