For example Fedora 26 should come with GCC 7.1 and mass rebuild is expected next month.
xrootd is still at 4.5 for Fedora 26 thus it still will need a fix downstream.
Same for CMSSW (at least for now).
Btw, is there ETA for 4.6?
david
> On 16 Jan 2017, at 18:33, Andrew Hanushevsky <[log in to unmask]> wrote:
>
> Yes, we did so on purpose. The old client is no longer supported and we no
> longer fix it. Starting with 4.6 it will also no longer be compiled so you
> wouldn'tsee that message. At 5.0 it will be completely removed.
>
> Andy
>
> On Mon, 16 Jan 2017, davidlt wrote:
>
> > You missed the following:
> > ```
> > src/XrdClient/XrdClient.cc: In member function 'virtual bool XrdClient::OpenFileWhenRedirected(char*, bool&)':
> > src/XrdClient/XrdClient.cc:1375:14: error: enum constant in boolean context [-Werror=int-in-bool-context]
> > options &= !kXR_delete;
> > ^~~~~~~~~~
> > src/XrdClient/XrdClient.cc:1383:14: error: enum constant in boolean context [-Werror=int-in-bool-context]
> > options &= !kXR_new;
> > ^~~~~~~
> > ```
> > You are using boolean operation where you needed a bitwise operation.
> >
> > ```
> > src/XrdCl/XrdClZipArchiveReader.cc: In destructor 'XrdCl::ZipArchiveReaderImpl::~ZipArchiveReaderImpl()':
> > src/XrdCl/XrdClZipArchiveReader.cc:246:23: error: ignoring return value of 'XrdCl::XRootDStatus XrdCl::File::Close(uint16_t)', declared with attribute warn_unused_result [-Werror=unused-result]
> > pArchive.Close();
> > ^
> > In file included from src/XrdCl/XrdClZipArchiveReader.cc:27:0:
> > src/XrdCl/XrdClFile.hh:121:20: note: declared here
> > XRootDStatus Close( uint16_t timeout = 0 ) XRD_WARN_UNUSED_RESULT;
> > ^~~~~
> > ```
> >
> > I am not fully sure how to properly handle this inside `~ZipArchiveReaderImpl()`. I know, that only saving return value (but not using it) already removed the error, but is not a right solution probably. Maybe dtor should be marked as `noexcept(false)` and should throw an exception/terminate.
> >
> > Will check further. Now it compiles up to 71%.
> >
> > --
> > You are receiving this because you commented.
> > Reply to this email directly or view it on GitHub:
> > https://github.com/xrootd/xrootd/pull/448#issuecomment-272914148
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/xrootd/xrootd/pull/448#issuecomment-272922305>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMB47TEOLDAPP3jHrUFUfPFgUR5Feg_ks5rS6n2gaJpZM4Li0Tn>.
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@davidlt in #448: For example Fedora 26 should come with GCC 7.1 and mass rebuild is expected next month.\nxrootd is still at 4.5 for Fedora 26 thus it still will need a fix downstream.\n\nSame for CMSSW (at least for now).\n\nBtw, is there ETA for 4.6?\n\ndavid\n\n\u003e On 16 Jan 2017, at 18:33, Andrew Hanushevsky \[log in to unmask]\u003e wrote:\n\u003e \n\u003e Yes, we did so on purpose. The old client is no longer supported and we no \n\u003e longer fix it. Starting with 4.6 it will also no longer be compiled so you \n\u003e wouldn'tsee that message. At 5.0 it will be completely removed.\n\u003e \n\u003e Andy\n\u003e \n\u003e On Mon, 16 Jan 2017, davidlt wrote:\n\u003e \n\u003e \u003e You missed the following:\n\u003e \u003e ```\n\u003e \u003e src/XrdClient/XrdClient.cc: In member function 'virtual bool XrdClient::OpenFileWhenRedirected(char*, bool\u0026)':\n\u003e \u003e src/XrdClient/XrdClient.cc:1375:14: error: enum constant in boolean context [-Werror=int-in-bool-context]\n\u003e \u003e options \u0026= !kXR_delete;\n\u003e \u003e ^~~~~~~~~~\n\u003e \u003e src/XrdClient/XrdClient.cc:1383:14: error: enum constant in boolean context [-Werror=int-in-bool-context]\n\u003e \u003e options \u0026= !kXR_new;\n\u003e \u003e ^~~~~~~\n\u003e \u003e ```\n\u003e \u003e You are using boolean operation where you needed a bitwise operation.\n\u003e \u003e\n\u003e \u003e ```\n\u003e \u003e src/XrdCl/XrdClZipArchiveReader.cc: In destructor 'XrdCl::ZipArchiveReaderImpl::~ZipArchiveReaderImpl()':\n\u003e \u003e src/XrdCl/XrdClZipArchiveReader.cc:246:23: error: ignoring return value of 'XrdCl::XRootDStatus XrdCl::File::Close(uint16_t)', declared with attribute warn_unused_result [-Werror=unused-result]\n\u003e \u003e pArchive.Close();\n\u003e \u003e ^\n\u003e \u003e In file included from src/XrdCl/XrdClZipArchiveReader.cc:27:0:\n\u003e \u003e src/XrdCl/XrdClFile.hh:121:20: note: declared here\n\u003e \u003e XRootDStatus Close( uint16_t timeout = 0 ) XRD_WARN_UNUSED_RESULT;\n\u003e \u003e ^~~~~\n\u003e \u003e ```\n\u003e \u003e\n\u003e \u003e I am not fully sure how to properly handle this inside `~ZipArchiveReaderImpl()`. I know, that only saving return value (but not using it) already removed the error, but is not a right solution probably. Maybe dtor should be marked as `noexcept(false)` and should throw an exception/terminate.\n\u003e \u003e\n\u003e \u003e Will check further. Now it compiles up to 71%.\n\u003e \u003e\n\u003e \u003e -- \n\u003e \u003e You are receiving this because you commented.\n\u003e \u003e Reply to this email directly or view it on GitHub:\n\u003e \u003e https://github.com/xrootd/xrootd/pull/448#issuecomment-272914148\n\u003e —\n\u003e You are receiving this because you authored the thread.\n\u003e Reply to this email directly, view it on GitHub \u003chttps://github.com/xrootd/xrootd/pull/448#issuecomment-272922305\u003e, or mute the thread \u003chttps://github.com/notifications/unsubscribe-auth/AAMB47TEOLDAPP3jHrUFUfPFgUR5Feg_ks5rS6n2gaJpZM4Li0Tn\u003e.\n\u003e \n\n"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/448#issuecomment-272932629"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1