Print

Print

The signature in 4.5.0 was

// Initializes an ssl ctx
virtual int Init(SSL_CTX *, int) = 0;

So if you wanted to make it backward compatible I don't think this was right. Brian's (@xrootd-dev) comment read:

i.e. the not pure virtual comment referred to InitSSL and FreeSSL, not Init.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ellert in #471: The signature in 4.5.0 was\r\n\r\n // Initializes an ssl ctx\r\n virtual int Init(SSL_CTX *, int) = 0;\r\n\r\nSo if you wanted to make it backward compatible I don't think this was right. Brian's (@xrootd-dev) comment read:\r\n\r\n\u003e - Rename InitCtx back to the original Init\r\n\u003e - Make InitSSL / FreeSSL not pure-virtual (put in the trivial inline implementation in the base class).\r\n\r\ni.e. the not pure virtual comment referred to InitSSL and FreeSSL, not Init.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/471#issuecomment-282670610"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1