Hi Mattias,
I see what you mean, there is a difference, in that respect. But adding that flexibility would be a way to hide a problem. I have cross-checked that no server version was supposed to drop the '.0' from the line sent back to the client, so there is a real problem with that old server, running an unmaintained version of XRootD, probably a buffer overflow or similar.
I do not think it is a good idea to change the code to accommodate for a bug in a deprecated version.
I think we should just revert this patch and fix the other problems with the current version that you have spotted and provided possible fixes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gganis in #464: Hi Mattias,\r\nI see what you mean, there is a difference, in that respect. But adding that flexibility would be a way to hide a problem. I have cross-checked that no server version was supposed to drop the '.0' from the line sent back to the client, so there is a real problem with that old server, running an unmaintained version of XRootD, probably a buffer overflow or similar.\r\nI do not think it is a good idea to change the code to accommodate for a bug in a deprecated version.\r\nI think we should just revert this patch and fix the other problems with the current version that you have spotted and provided possible fixes. "}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/464#issuecomment-281142289"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1