Well, the issue now is that XrdHttp/XrdHttpSecXtractor.hh is in the public
header section. It should have been in the private header section since
it's part of the compiled package and no user would actually use it.
According to EPEL rules we can't move it until a major release change. Of
course, given the circumstances we could get dispensation but that is up
to Mattias.
Andy
On Mon, 20 Feb 2017, xrootd-dev wrote:
> Hi,
>
> I never knew that the SecXtractor was considered
> a public interface, for sure that was not
> intended. Was it ?
>
> The recent changes wanted to comply with the guidelines
> for xrootd plugins loading, in order to make it possible to
> become a public interface with version checking, etc.
>
> Andy ? What do you prefer that we do here ?
>
> f
>
>
>
>
>
>
> On 02/20/2017 05:02 PM, ellert wrote:
>> I have received additional comments on the 4.6.0 update in EPEL testing:
>>
>> https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9b2cd39ee3
>>
>> First comment:
>>
>> It appears this PR breaks ABI / API compatibility in the XrdSecXtractor interface: #444
>> <https://github.com/xrootd/xrootd/pull/444>
>>
>> My plugin https://github.com/bbockelm/xrootd-lcmaps fails to compile after the update.
>> karma: -1
>>
>> Second comment:
>>
>> The configuration of for the pfc.* attributes changed, meaning existing configurations that use the caching proxy fail to
>> start after upgrade.
>>
>> The old-style attributes should still be permitted (especially as there appears to be a simple translation between old and new).
>>
>> PR #444 <https://github.com/xrootd/xrootd/pull/444> that is referenced does mention that there is breakage, so maybe this was
>> intentional?
>>
>> ÿÿ
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub <https://github.com/xrootd/xrootd/issues/470>, or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AD7YjnupBw1VGCbk4ExabxslSJfCOXtnks5rebkAgaJpZM4MGWj1>.
>>
>>
>> --------------------------------------------------------------------------------------------------------------------------------
>>
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the XROOTD-DEV list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
>>
>
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/issues/470#issuecomment-281127802
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #470: Well, the issue now is that XrdHttp/XrdHttpSecXtractor.hh is in the public \nheader section. It should have been in the private header section since \nit's part of the compiled package and no user would actually use it. \nAccording to EPEL rules we can't move it until a major release change. Of \ncourse, given the circumstances we could get dispensation but that is up \nto Mattias.\n\nAndy\n\nOn Mon, 20 Feb 2017, xrootd-dev wrote:\n\n\u003e Hi,\n\u003e\n\u003e I never knew that the SecXtractor was considered\n\u003e a public interface, for sure that was not\n\u003e intended. Was it ?\n\u003e\n\u003e The recent changes wanted to comply with the guidelines\n\u003e for xrootd plugins loading, in order to make it possible to\n\u003e become a public interface with version checking, etc.\n\u003e\n\u003e Andy ? What do you prefer that we do here ?\n\u003e\n\u003e f\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e On 02/20/2017 05:02 PM, ellert wrote:\n\u003e\u003e I have received additional comments on the 4.6.0 update in EPEL testing:\n\u003e\u003e\n\u003e\u003e https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9b2cd39ee3\n\u003e\u003e\n\u003e\u003e First comment:\n\u003e\u003e\n\u003e\u003e It appears this PR breaks ABI / API compatibility in the XrdSecXtractor interface: #444\n\u003e\u003e \u003chttps://github.com/xrootd/xrootd/pull/444\u003e\n\u003e\u003e\n\u003e\u003e My plugin https://github.com/bbockelm/xrootd-lcmaps fails to compile after the update.\n\u003e\u003e karma: -1\n\u003e\u003e\n\u003e\u003e Second comment:\n\u003e\u003e\n\u003e\u003e The configuration of for the pfc.* attributes changed, meaning existing configurations that use the caching proxy fail to\n\u003e\u003e start after upgrade.\n\u003e\u003e\n\u003e\u003e The old-style attributes should still be permitted (especially as there appears to be a simple translation between old and new).\n\u003e\u003e\n\u003e\u003e PR #444 \u003chttps://github.com/xrootd/xrootd/pull/444\u003e that is referenced does mention that there is breakage, so maybe this was\n\u003e\u003e intentional?\n\u003e\u003e\n\u003e\u003e ÿÿ\n\u003e\u003e You are receiving this because you are subscribed to this thread.\n\u003e\u003e Reply to this email directly, view it on GitHub \u003chttps://github.com/xrootd/xrootd/issues/470\u003e, or mute the thread\n\u003e\u003e \u003chttps://github.com/notifications/unsubscribe-auth/AD7YjnupBw1VGCbk4ExabxslSJfCOXtnks5rebkAgaJpZM4MGWj1\u003e.\n\u003e\u003e\n\u003e\u003e\n\u003e\u003e --------------------------------------------------------------------------------------------------------------------------------\n\u003e\u003e\n\u003e\u003e Use REPLY-ALL to reply to list\n\u003e\u003e\n\u003e\u003e To unsubscribe from the XROOTD-DEV list, click the following link:\n\u003e\u003e https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV\u0026A=1\n\u003e\u003e\n\u003e\n\u003e\n\u003e -- \n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly or view it on GitHub:\n\u003e https://github.com/xrootd/xrootd/issues/470#issuecomment-281127802"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/470#issuecomment-281219301"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
