File ref-counts are made from CacheIO objects and from sync tasks. This common management of usage somewhat simplifies the destruction of CacheIO and File objects. There is a bunch of white-space changes I couldn't refrain myself from doing while reviewing the code. You can view, comment on, or merge this pull request online at: https://github.com/xrootd/xrootd/pull/510 -- Commit Summary -- * Introduce File reference count to pass the object between IO. * Avoid double sync in Detach(). Code review and cleanup. -- File Changes -- M src/XrdFileCache/XrdFileCache.cc (193) M src/XrdFileCache/XrdFileCache.hh (58) M src/XrdFileCache/XrdFileCacheFile.cc (130) M src/XrdFileCache/XrdFileCacheFile.hh (53) M src/XrdFileCache/XrdFileCacheIO.hh (19) M src/XrdFileCache/XrdFileCacheIOEntireFile.cc (92) M src/XrdFileCache/XrdFileCacheIOEntireFile.hh (9) M src/XrdFileCache/XrdFileCacheIOFileBlock.cc (71) M src/XrdFileCache/XrdFileCacheIOFileBlock.hh (6) M src/XrdFileCache/XrdFileCacheInfo.cc (4) -- Patch Links -- https://github.com/xrootd/xrootd/pull/510.patch https://github.com/xrootd/xrootd/pull/510.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/510 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1