 |
 |
Hi Brian, If I run makerpm.sh with your PR I'm getting the following version: > 4.6.1.pre-0.165.git.g7184a9f which is not in line with what you described, right? I would expect to have: > 4.6.2.pre-0.165.git.7184a9fc The $BUG should have been bumped, and short hash should point to the last commit, right? Anyway, let's assume it works correctly for now, so if I create the pre-release version I'll get correctly: > 4.6.2.pre-0.165.git.7184a9fc And let's assume the next release will be 4.6.2-1. Lets do: > rpmdev-vercmp 4.6.2-1 4.6.2.pre-0.165.git.7184a9fc > 4.6.2-1 < 4.6.2.pre-0.165.git.7184a9fc This means yum will think the pre-release is a higher version than the actual release. Similarly if we would have a release candidate: 4.6.2-0.rc1: > rpmdev-vercmp 4.6.2-0.rc1 4.6.2.pre-0.165.git.7184a9fc > 4.6.2-0.rc1 < 4.6.2.pre-0.165.git.7184a9fc Again the same problem. So it needs some rethinking ;-) We could try something like: 4.6.1-1.pr521.165.git.7184a9fc Where '4.6.1-1' is the latest release, 'pr521' is the branch name, 165 is the number of commits since last release, and '7184a9fc' is the short hash of the last commit. Just an idea. Cheers, Michal -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/521#issuecomment-304290099 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1