 |
 |
@bbockelm why to drop ```-Wall```? Let me explain how I faced with these two issues from GCC and found that GCC may be right here. As for ```array-bounds``` (```XrdXrootdJob```) at first I thought that GCC is wrong here, because code looks innocent, I even prepared small example that gives zero messages from GCC though I compiled it with ```-Wall -Wextra -pedantic``` (I think it is enough to trigger maximum number of checks). Looking more closely to the code I found that method ```addClient``` assumes that it is possible (how?) to have more than ```maxClients``` clients. I think GCC here warns because it "thinks" that here possible situation when array index goes beyond the limit. I didn't dig dipper into the code and didn't try to make correct example which will give always false-positive message from GCC. The second place where GCC stops with ```nonnull``` (```XrdCnsSsi```) looks more suspicious. I would assume that someone can pass null pointer (just zero) to the ```Updt``` method. IMHO, if compilation stops due to ```-Wall``` then it is worth to check the code and to improve it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/issues/522#issuecomment-304820777 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1