Print

Print


@bbockelm : My bad, I thought you are using some random git hash for the devel branches, but you are actually using the right one prefixed with a 'g' as in git describe. 

Two questions:

1. Why do you need the SHA1 hash in the RPM release?

2. Why would we need the 4.6.99 ?
> NOTE: when master is pointing at a new release series, we should then
> tag something along the lines of the next release. For example, once
> master is pointing at 4.7.x, we should make a tag of 4.6.99.


Regarding the branching and tagging, we have a stable branch per 'minor' release (e.g. stable-4.6.x), both RC and release tags go to the stable branches. And I think that's it. 
(I will be merging the stable branches back to master starting with the next release, it seems to me like a reasonable thing to do).

In general I'm not against your idea, I think we just need to iron out the details ;-)

Would the following schema work for you:
xrootd-4.6.1-1.master.91.c41d4c13

This is very intuitive: it's 4.6.1-1 + 91 commits from branch master, the last one of them being c41d4c13.

I would skip both the 'g' and 'git' as we are using only git anyway. I think we can leave out the 'pre' interfix, as it carries no additional info.
(Also, it would be awesome,  if we could have a switch that allows to replace the 91 with a value chosen by the user.)

4.6.1-1 < 4.6.1-1.master.91.gc41d4c1 && 4.6.1-2 > 4.6.1-1.master.91.c41d4c13
which is what we want, right?

Let me know your thoughts!

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/521#issuecomment-305176543

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1