Thank you for the detailed review and recommendation. I agree that we are misusing ENOSYS and should revert to using ENOTSUP. However, the pull request only changes the error code mapping. A more complete solution would be to change all active returns of ENOSYS to ENOTSUP. This would provide for better consistency and avoid making the same mistake in the future. Would you agree?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #516: Thank you for the detailed review and recommendation. I agree that we are misusing ENOSYS and should revert to using ENOTSUP. However, the pull request only changes the error code mapping. A more complete solution would be to change all active returns of ENOSYS to ENOTSUP. This would provide for better consistency and avoid making the same mistake in the future. Would you agree?"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/516#issuecomment-301672381"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1