Print

Print


Yes, the documentation is wrong. It was written before the implementation and, unfortunately, the implementation took a different path. We try hard to avoid that mistake but it does happen. We have to options (pick one considering the side-effects):
1) We correct the documentation. This is the easiest route as it does not change any code.
2) We change the code to correspond to the docs by adding an isNil response type. Not a big change and I doubt anyone will notice but it does mean anyone who is banking on isData for a null response detection will be unpleasantly surprised as this is an ABI breaker. Though we haven't yet put this in the public sphere.
so?

In this particular case I really have to disagree with you. isNone is a valid enum that you can use for any purpose you want and should not be concerned how it is used by the implementation because, frankly, your code is never exposed to it.

The last item confuses me. Where are you calling GetMetadata() from? I would hope from the ProcessResponse() callback because otherwise the return results are not guaranteed to be timely. If you call it from ProcessResponse() then you already have what the response will look like via the passed response info structure.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/issues/546#issuecomment-317883756

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1