OK, then the documentation is misleading. The SSI documentation (p.22) says, "A metadata-only response is indicated when XrdSsiRespInfo::rType is set to isNil (i.e. no response data is present)." isNil is not defined in the enum. When I looked at the headers, I found isNone, and assumed that was what was meant.
IMHO, a good API design should not expose implementation details as it can lead to unintended dependencies. It would be better to use a private member variable to store whether a Response has been received. You already have isError for invalid responses. But at the very least you could change isNone to something less confusing, like isInvalid.
Also, is there any way to tell whether a message is metadata-only, besides calling GetResponseData()? The documentation implies that there should be. I would like to avoid allocating a buffer to receive the response in the case where there is no response data.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@slithy in #546: OK, then the documentation is misleading. The SSI documentation (p.22) says, \"A metadata-only response is indicated when XrdSsiRespInfo::rType is set to isNil (i.e. no response data is present).\" isNil is not defined in the enum. When I looked at the headers, I found isNone, and assumed that was what was meant.\r\n\r\nIMHO, a good API design should not expose implementation details as it can lead to unintended dependencies. It would be better to use a private member variable to store whether a Response has been received. You already have isError for invalid responses. But at the very least you could change isNone to something less confusing, like isInvalid.\r\n\r\nAlso, is there any way to tell whether a message is metadata-only, besides calling GetResponseData()? The documentation implies that there should be. I would like to avoid allocating a buffer to receive the response in the case where there is no response data."}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/546#issuecomment-317671537"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
