On systems where char by default is unsigned compilation fails with:

/builddir/build/BUILD/xrootd-4.7.0/src/XrdSsi/XrdSsiShMam.cc: In member function 'virtual bool XrdSsiShMam::Resize(XrdSsiShMat::CRZParms&)':
/builddir/build/BUILD/xrootd-4.7.0/src/XrdSsi/XrdSsiShMam.cc:1128:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
    if (parms.reUse < 0) parms.reUse   = reUse;
                      ^
/builddir/build/BUILD/xrootd-4.7.0/src/XrdSsi/XrdSsiShMam.cc:1129:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
    if (parms.multW < 0) parms.multW   = multW;
                      ^
cc1plus: all warnings being treated as errors
make[2]: Leaving directory `/builddir/build/BUILD/xrootd-4.7.0/build'
make[2]: *** [src/CMakeFiles/XrdSsiShMap.dir/XrdSsi/XrdSsiShMam.cc.o] Error 1

This pull request fixes the issue.

Affected (char is unsigned by default):

Not affected (char is signed by default):

See: https://koji.fedoraproject.org/koji/taskinfo?taskID=21518473

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/572

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix comparison always false error (#572)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/572"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1