Print

Print


  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 08d4646697e5bde817f0ba0abdff4ae6152fee67
      https://github.com/xrootd/xrootd/commit/08d4646697e5bde817f0ba0abdff4ae6152fee67
  Author: Georgios Bitzes <[log in to unmask]>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M src/XrdCl/XrdClUtils.hh

  Log Message:
  -----------
  [XrdCl] Fix error checking when setting sec.uid, sec.gid

Previously, I was calling setfsuid(-1) to check if the
previous call had succeeded, since this syscall will
always return the current fsuid, whether the syscall
itself succeeded or not. There's no way to check
other than calling setfsuid again, since there's no
getfsuid.

The expectation was that setfsuid(-1) will always fail
and not affect the fsuid, effectively acting as getfsuid,
but it appears that on SLC6 it succeeds, setting the
fsuid to.. 4294967295. On Fedora 26 it fails as expected,
I have no idea why there's a difference.

Instead, let's use setfsuid(pFsUid) again, just to
check if the previous call succeeded.


  Commit: cd3379096e346f2bc2694f78328d94bee36d88dc
      https://github.com/xrootd/xrootd/commit/cd3379096e346f2bc2694f78328d94bee36d88dc
  Author: Georgios Bitzes <[log in to unmask]>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M src/XrdCl/XrdClUtils.hh
    M src/XrdCl/XrdClXRootDTransport.cc

  Log Message:
  -----------
  [XrdCl] Stop ignoring return values of setfsuid, setfsgid


  Commit: 0382558ace0034042b3a6a851e7b7ff55e2dd404
      https://github.com/xrootd/xrootd/commit/0382558ace0034042b3a6a851e7b7ff55e2dd404
  Author: simonmichal <[log in to unmask]>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M src/XrdCl/XrdClUtils.hh
    M src/XrdCl/XrdClXRootDTransport.cc

  Log Message:
  -----------
  Merge pull request #605 from gbitzes/fsuid-bugfix

[XrdCl] Fix error checking when setting sec.uid, sec.gid


Compare: https://github.com/xrootd/xrootd/compare/15840adeaf63...0382558ace00

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1