Branch: refs/heads/stable-4.7.x
Home: https://github.com/xrootd/xrootd
Commit: 900779e281ce1c687a36fb33267360d807d777e2
https://github.com/xrootd/xrootd/commit/900779e281ce1c687a36fb33267360d807d777e2
Author: Georgios Bitzes <[log in to unmask]>
Date: 2017-10-24 (Tue, 24 Oct 2017)
Changed paths:
M src/XrdCl/XrdClUtils.hh
Log Message:
-----------
[XrdCl] Fix error checking when setting sec.uid, sec.gid
Previously, I was calling setfsuid(-1) to check if the
previous call had succeeded, since this syscall will
always return the current fsuid, whether the syscall
itself succeeded or not. There's no way to check
other than calling setfsuid again, since there's no
getfsuid.
The expectation was that setfsuid(-1) will always fail
and not affect the fsuid, effectively acting as getfsuid,
but it appears that on SLC6 it succeeds, setting the
fsuid to.. 4294967295. On Fedora 26 it fails as expected,
I have no idea why there's a difference.
Instead, let's use setfsuid(pFsUid) again, just to
check if the previous call succeeded.
Commit: d8f11607a87f1ea0652b8f3e563d3a89876c805e
https://github.com/xrootd/xrootd/commit/d8f11607a87f1ea0652b8f3e563d3a89876c805e
Author: Georgios Bitzes <[log in to unmask]>
Date: 2017-10-24 (Tue, 24 Oct 2017)
Changed paths:
M src/XrdCl/XrdClUtils.hh
M src/XrdCl/XrdClXRootDTransport.cc
Log Message:
-----------
[XrdCl] Stop ignoring return values of setfsuid, setfsgid
Compare: https://github.com/xrootd/xrootd/compare/b154a0d46074...d8f11607a87f
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
