Yeah - I think that one might have even been the one I originally forked a few years ago (and have copy / pasted ever since)! Here's the latest revision on my end:
https://github.com/bbockelm/xrootd-multiuser/blob/master/cmake/FindXrootd.cmake
@simonmichal - I'm starting to think what a PR would look like. One big conceptual question: do we want the COMPONENTS arguments of the macro to map to source code components (OFS / ACC / XRDCL etc) or packaging components (SERVER / CLIENT / CORE / PRIVATE)?
The former would likely be more meaningful to developers, as they are likely looking at the source code. The latter would help us stay sane (less components!) because it would better match the existing packaging structures.
Just for reference - here's the upstream docs: https://cmake.org/Wiki/CMake:How_To_Find_Libraries. Seems that there's a reasonable set of helper macros we can either use directly or copy/paste (probably the latter, given the vintage of CMake we use...).
Note: I'm on vacation for approximately the next week - may be a bit before I can return to this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm in #582: Yeah - I think that one might have even been the one I originally forked a few years ago (and have copy / pasted ever since)! Here's the latest revision on my end:\r\n\r\nhttps://github.com/bbockelm/xrootd-multiuser/blob/master/cmake/FindXrootd.cmake\r\n\r\n@simonmichal - I'm starting to think what a PR would look like. One big conceptual question: do we want the `COMPONENTS` arguments of the macro to map to source code components (`OFS` / `ACC` / `XRDCL` etc) or packaging components (`SERVER` / `CLIENT` / `CORE` / `PRIVATE`)?\r\n\r\nThe former would likely be more meaningful to developers, as they are likely looking at the source code. The latter would help us stay sane (less components!) because it would better match the existing packaging structures.\r\n\r\nJust for reference - here's the upstream docs: https://cmake.org/Wiki/CMake:How_To_Find_Libraries. Seems that there's a reasonable set of helper macros we can either use directly or copy/paste (probably the latter, given the vintage of CMake we use...).\r\n\r\nNote: I'm on vacation for approximately the next week - may be a bit before I can return to this."}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/582#issuecomment-333584301"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
