The test to see if there is an external plugin was inverted, meaning the wrong case in the conditional was always called. This fixes the logic, avoiding a `SIGSEGV` I encountered while testing the improved `XrdHttp` code.
Additionally, this reverses the order of evaluation -- checking the (cheap, common) pointer value first, then invoking a function.
@ffurano
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/611
-- Commit Summary --
* Correct external handling logic.
-- File Changes --
M src/XrdHttp/XrdHttpProtocol.cc (26)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/611.patch
https://github.com/xrootd/xrootd/pull/611.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/611
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
