Print

Print

readline.h uses the FILE datatype from stdio.h, without an #include for that system header. Upstream documents that it is the responsibility of any code using readline.h to include that other header itself, and relies on the fact that it is documented to declare that this is not a bug. Some distros patch their readline.h with this dependent #include, but for maximum portability the READLINE compile-test function should do it.

The xroot4 source files that use readline.h have includes for stdio.h (or cstdio) already.

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/652

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"readline.h requires stdio.h to be compileable (#652)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/652"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1