Print

Print

@simonmichal commented on this pull request.

In src/XrdDig/XrdDigAuth.cc:

> @@ -233,10 +233,6 @@ bool XrdDigAuth::Parse(XrdOucStream &aFile, int lNum)
    int  k, n, bLeft = sizeof(buff);
    bool aOK = false, tfVal;
 
-// Clear the arec the fastest way possible
-//
-   memset(aEnt.eP, 0, sizeof(XrdDigAuthEnt));
-

Again, the compiler was complaining that an object with a non-trivial constructor is being initialized with memset.

Now the fix rational:

aEnt.eP is a newly created instance of 'XrdDigAuthEnt':
https://github.com/xrootd/xrootd/blob/fedora-rawhide-fix/src/XrdDig/XrdDigAuth.cc#L227

note that I modified the default constructor of 'XrdDigAuthEnt' :
60da79d#diff-a726e008bf733c6a23ce19da88801122R56

now, it initializes all the members to 0, and clears member arrays, so it is equivalent to the memset I removed.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonmichal commented on #657"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/657#discussion_r167493140"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1