Print

Print

@simonmichal commented on this pull request.

In src/XrdSec/XrdSecEntity.hh:

> @@ -69,13 +69,29 @@ const    char   *tident;                  // Trace identifier always preset
                                           // it in your XrdSfsFileSystem::Disc()
                                           // implementation, as needed.
          XrdSecEntity(const char *pName = "")
-                     : name(0), host(0), vorg(0), role(0), grps(0),
-                       endorsements(0), moninfo(0), creds(0), credslen(0),
-                       rsvd(0), addrInfo(0), tident(""), sessvar(0)
-                     {strncpy(prot, pName, XrdSecPROTOIDSIZE-1);
+                     {Reset();
+	              strncpy(prot, pName, XrdSecPROTOIDSIZE-1);
                       prot[XrdSecPROTOIDSIZE-1] = '\0';

The code compiled against the old version of constructor will have the old version of the constructor inlined, there's no ABI compatibility problem. The new and the old version of the constructor are functionally equivalent so it is OK.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonmichal commented on #657"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/657#discussion_r167495897"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1