gganis commented on this pull request.
> //
-#if 0
- retc2 = lstat(local_path_New, &statbuff);
- if (!retc2) return -EEXIST;
-#endif
+ if (!(retc2 = lstat(local_path_New, &statbuff)))
+ { if (remotefs || (statbuff.st_mode & S_IFMT) == S_IFLNK) return -EEXIST;
+ }
The symlink part comes from your original comment. In my case I am mostly interested to local file, no symlinks. However, I see that the man page of rename says that
if newpath refers to a symbolic link, the link will be overwritten
So I suggest that we only leave the check on 'remotefs'. What do you think?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/660#discussion_r171563928
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
