@gganis commented on this pull request.

In src/XrdOss/XrdOssRename.cc:

>  //
-#if 0
-   retc2 = lstat(local_path_New, &statbuff);
-   if (!retc2) return -EEXIST;
-#endif
+   if (!(retc2 = lstat(local_path_New, &statbuff)))
+      { if (remotefs || (statbuff.st_mode & S_IFMT) == S_IFLNK) return -EEXIST;
+      }

The symlink part comes from your original comment. In my case I am mostly interested to local file, no symlinks. However, I see that the man page of rename says that

if newpath refers to a symbolic link, the link will be overwritten

So I suggest that we only leave the check on 'remotefs'. What do you think?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gganis commented on #660"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/660#discussion_r171563928"}}}

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1