So, there's three distinct cases:
- File is read in total. In this case, it does open-read*-close.
- Read request against a part of the file. In this case, it does open-read*. This patch adds a close afterward.
- Vector read request. In this case, it does open-read*-close.
So, in the end, we're making things behave consistently (in addition to again being able to monitor via the f-stream).
I'm not opposed to doing another layer of file descriptors, but probably should fix this first.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm in #664: So, there's three distinct cases:\r\n1. File is read in total. In this case, it does open-read*-close.\r\n2. Read request against a part of the file. In this case, it does open-read*. This patch adds a close afterward.\r\n3. Vector read request. In this case, it does open-read*-close.\r\n\r\nSo, in the end, we're making things behave consistently (in addition to again being able to monitor via the f-stream).\r\n\r\nI'm not opposed to doing another layer of file descriptors, but probably should fix this first."}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/664#issuecomment-370474785"}}}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
