 |
 |
The other problem was there was a sequencing bug in the server that allowed duplicate opens during recovery. That’s corrected for 4.8.2 and, I’m pretty confident that is sufficient for most cases. Steven does point out an aberrant case (very small file writes) that could escape that fix. That would require fixing the client’s handling of endsess. So, I think we will be doing that for 4.8.2 as well. Andy From: simonmichal Sent: Thursday, March 22, 2018 6:02 AM To: xrootd/xrootd Cc: Andrew Hanushevsky ; Mention Subject: Re: [xrootd/xrootd] C++ API to XRootD should allow the "open file" retry logic to be turned off (#673) From what it see in XrdXrootdProtocol::do_Endsess() it can happen that the server actually responds with kXR_wait to an kXR_endsess request (@abh3 : could you confirm?): https://github.com/xrootd/xrootd/blob/master/src/XrdXrootd/XrdXrootdXeq.cc#L711-L712 I think the kXR_wait response is not taken into account on the client side logic: https://github.com/xrootd/xrootd/blob/master/src/XrdCl/XrdClXRootDTransport.cc#L2012-L2036 If the response is not an error the client declares the handshake as successful (@ljanyst : could you give me another 'holy shit' if you think this might be true? ;-). This could be the source of our problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/issues/673#issuecomment-375458191 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1