Thanks for the heads up. This has been corrected.
Andy
On Mon, 28 May 2018, Sebastien Binet wrote:
> this was uncovered in https://github.com/go-hep/hep/pull/195 (thanks @EgorMatirov!).
>
> it seems the [specs](http://xrootd.org/doc/dev45/XRdv310.pdf) for `ClientProtocolRequest` say (p71):
> ```
> Request
> kXR_char streamid[2]
> kXR_unt16 kXR_protocol
> kXR_int32 clientpv
> kXR_char reserved[11]
> kXR_char options
> kXR_int32 0
> ```
>
> while [XProtocol/XProtocol.hh@d96a61a](https://github.com/xrootd/xrootd/blob/d96a61a07947e75e69cd2eed8c3cbcc86ee0e52c/src/XProtocol/XProtocol.hh#L480):
> ```c++
> struct ClientProtocolRequest {
> kXR_char streamid[2];
> kXR_unt16 requestid;
> kXR_int32 clientpv; // 2.9.7 or higher
> kXR_char flags; // 3.1.0 or higher
> kXR_char reserved[11];
> kXR_int32 dlen;
> };
> ```
>
> _ie:_ the order of `reserved[11]` and `options` from the specs are reversed in the implementation.
>
> I guess updating the `specs` is easier :)
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/issues/717
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/xrootd/xrootd/issues/717#issuecomment-392612896","url":"https://github.com/xrootd/xrootd/issues/717#issuecomment-392612896","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #717: Thanks for the heads up. This has been corrected.\n\nAndy\n\nOn Mon, 28 May 2018, Sebastien Binet wrote:\n\n\u003e this was uncovered in https://github.com/go-hep/hep/pull/195 (thanks @EgorMatirov!).\n\u003e\n\u003e it seems the [specs](http://xrootd.org/doc/dev45/XRdv310.pdf) for `ClientProtocolRequest` say (p71):\n\u003e ```\n\u003e Request\n\u003e kXR_char streamid[2]\n\u003e kXR_unt16 kXR_protocol\n\u003e kXR_int32 clientpv\n\u003e kXR_char reserved[11]\n\u003e kXR_char options\n\u003e kXR_int32 0\n\u003e ```\n\u003e\n\u003e while [XProtocol/XProtocol.hh@d96a61a](https://github.com/xrootd/xrootd/blob/d96a61a07947e75e69cd2eed8c3cbcc86ee0e52c/src/XProtocol/XProtocol.hh#L480):\n\u003e ```c++\n\u003e struct ClientProtocolRequest {\n\u003e kXR_char streamid[2];\n\u003e kXR_unt16 requestid;\n\u003e kXR_int32 clientpv; // 2.9.7 or higher\n\u003e kXR_char flags; // 3.1.0 or higher\n\u003e kXR_char reserved[11];\n\u003e kXR_int32 dlen;\n\u003e };\n\u003e ```\n\u003e\n\u003e _ie:_ the order of `reserved[11]` and `options` from the specs are reversed in the implementation.\n\u003e\n\u003e I guess updating the `specs` is easier :)\n\u003e\n\u003e -- \n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly or view it on GitHub:\n\u003e https://github.com/xrootd/xrootd/issues/717\n"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/717#issuecomment-392612896"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [xrootd/xrootd] specs: ClientProtocolRequest binary layout not implemented as specs (#717)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 717,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 717\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/717#issuecomment-392612896"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 339780278\n}"
}
],
"themeColor": "26292E"
}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
