These breaks compilation with the error below on my machine.
xrootd-4.8.3/tests/XrdSsiTests/XrdShMap.cc:
In function ‘int DoA32(const char*)’:
xrootd-4.8.3/tests/XrdSsiTests/XrdShMap.cc:418:34:
error: expected initializer before ‘OF’
ZEXTERN uLong ZEXPORT adler32 OF((uLong adler, const Bytef *buf, uInt len));
^^
This PR is a fix for issue #708.
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/709
Commit Summary
- Remove declarations of crc32 and adler32
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Remove declarations of crc32 and adler32 (#709)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/709"}}}
{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Remove declarations of crc32 and adler32 (#709)","sections":[{"text":"","activityTitle":"**Guilherme Amadio**","activityImage":"https://avatars2.githubusercontent.com/u/249404?s=160\u0026v=4","activitySubtitle":"@amadio","facts":[]},{"title":"Commit Summary","facts":[{"name":"64f81b7","value":"Remove declarations of crc32 and adler32"}]},{"title":"File Changes","facts":[{"name":"Modified","value":"[src/XrdSsi/XrdSsiShMam.cc](https://github.com/xrootd/xrootd/pull/709/files#diff-0) (2 changes)"},{"name":"Modified","value":"[tests/XrdSsiTests/XrdShMap.cc](https://github.com/xrootd/xrootd/pull/709/files#diff-1) (3 changes)"}]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"xrootd/xrootd\",\"issueId\":709,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"xrootd/xrootd\",\"pullRequestId\":709}"},{"targets":[{"os":"default","uri":"https://github.com/xrootd/xrootd/pull/709"}],"@type":"OpenUri","name":"View on GitHub"},{"targets":[{"os":"default","uri":"https://github.com/xrootd/xrootd/pull/709.patch"}],"@type":"OpenUri","name":"View patch"},{"targets":[{"os":"default","uri":"https://github.com/xrootd/xrootd/pull/709.diff"}],"@type":"OpenUri","name":"View diff"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":336705937}"}],"themeColor":"26292E"}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
