This change introduces a new method which translates from an Xrd error code into an appropriate HTTP
status code.
It introduces 2 new private variables in XrdHttpReq: httpStatusCode
& httpStatusText
.
httpStatusCode
: HTTP Status compliant code
httpStatusText
: the Xrd error text, if present, or a minimal description otherwise
Default values are 500 and "Unrecognized error".
During the request post-processing, the branches which end in an error will send back the status code and text mentioned above.
This pull request addresses issue #713
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/735
Commit Summary
- Map Xrd error codes to HTTP status codes
- Add newline to HTTP Status text
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/xrootd/xrootd/pull/735","url":"https://github.com/xrootd/xrootd/pull/735","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"XrdHttp: Xrd error code to HTTP status translation (#735)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/735"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "XrdHttp: Xrd error code to HTTP status translation (#735)",
"sections": [
{
"text": "",
"activityTitle": "**mpatrascoiu**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mpatrascoiu",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "620bf7f",
"value": "Map Xrd error codes to HTTP status codes"
},
{
"name": "6771b3c",
"value": "Add newline to HTTP Status text"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/XrdHttp/XrdHttpProtocol.cc](https://github.com/xrootd/xrootd/pull/735/files#diff-0) (7 changes)"
},
{
"name": "Modified",
"value": "[src/XrdHttp/XrdHttpReq.cc](https://github.com/xrootd/xrootd/pull/735/files#diff-1) (66 changes)"
},
{
"name": "Modified",
"value": "[src/XrdHttp/XrdHttpReq.hh](https://github.com/xrootd/xrootd/pull/735/files#diff-2) (6 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 735,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 735\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/735"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/735.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/735.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 344034475\n}"
}
],
"themeColor": "26292E"
}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1