 |
 |
bbockelm approved this pull request. Looks good to me! This actually solves a long-standing irritation for me. Only tweak (optional) is that you could provide the response size to `SendSimpleResp` (last argument) since we have this pre-calculated in the `std::string`. Without this size hint, the `SendSimpleResp` code will have an extra `strlen` call to the C-style string provided. Of course, this is very micro-optimization, given the size of the strings involved here... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/735#pullrequestreview-127639101 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1