@bbockelm approved this pull request.
Looks good to me! This actually solves a long-standing irritation for me.
Only tweak (optional) is that you could provide the response size to SendSimpleResp (last argument) since we have this pre-calculated in the std::string. Without this size hint, the SendSimpleResp code will have an extra strlen call to the C-style string provided.
Of course, this is very micro-optimization, given the size of the strings involved here...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/xrootd/xrootd/pull/735#pullrequestreview-127639101","url":"https://github.com/xrootd/xrootd/pull/735#pullrequestreview-127639101","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm approved #735"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/735#pullrequestreview-127639101"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@bbockelm approved 735",
"sections": [
{
"text": "Looks good to me! This actually solves a long-standing irritation for me.\r\n\r\nOnly tweak (optional) is that you could provide the response size to `SendSimpleResp` (last argument) since we have this pre-calculated in the `std::string`. Without this size hint, the `SendSimpleResp` code will have an extra `strlen` call to the C-style string provided.\r\n\r\nOf course, this is very micro-optimization, given the size of the strings involved here...",
"activityTitle": "**Brian Bockelman**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bbockelm",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/735#pullrequestreview-127639101"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 344034475\n}"
}
],
"themeColor": "26292E"
}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
