Here is a suggestion that would likely work:
a) Keep LIB_XRD_HTTP as a MODULE (maybe the variable should be renamed PLUGIN_XRD_HTTP.
b) In this module only include XrdHttpProtocol (you may want to research to see what other object files are only referenced by XrdHttpProtocol and include those as well).
c) Anything left over goins into libXrdHttpUtils.so (notice this does not have a plugin suffix).
d) The plugin modulewould also link against libXrdHttp.so.
Doing it this way keeps backward compatibility and adheres to EPEL packaging rules.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/xrootd/xrootd/pull/737#issuecomment-397274291","url":"https://github.com/xrootd/xrootd/pull/737#issuecomment-397274291","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #737: Here is a suggestion that would likely work:\r\na) Keep LIB_XRD_HTTP as a MODULE (maybe the variable should be renamed PLUGIN_XRD_HTTP.\r\nb) In this module only include XrdHttpProtocol (you may want to research to see what other object files are only referenced by XrdHttpProtocol and include those as well).\r\nc) Anything left over goins into libXrdHttpUtils.so (notice this does *not* have a plugin suffix).\r\nd) The plugin modulewould also link against libXrdHttp.so.\r\nDoing it this way keeps backward compatibility and adheres to EPEL packaging rules. "}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/737#issuecomment-397274291"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] HTTP TPC v2 (#737)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 737,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 737\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/737#issuecomment-397274291"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 344067830\n}"
}
],
"themeColor": "26292E"
}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
