I already have a working prototype for close (I think we already support it for opaque queries). It isn't the easiest to do as close is a complicated path that passively interacts with open().. Anyway, in the close() async response you can only do one final response: kXR_ok or kXR_error; that should be good enough. While the file is being closed a) he file remains locked in whatever mode it was locked in, and b) it's file handle is not reassigned. Once the final response is sent, the lock is dropped and the handle is available for reassignment. Any attempt to issue any operation against a file being closed will return a "file not open" error. I should have this committed in a week or so after some more testing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/xrootd/xrootd/issues/734#issuecomment-395853595","url":"https://github.com/xrootd/xrootd/issues/734#issuecomment-395853595","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #734: I already have a working prototype for close (I think we already support it for opaque queries). It isn't the easiest to do as close is a complicated path that passively interacts with open().. Anyway, in the close() async response you can only do one final response: kXR_ok or kXR_error; that should be good enough. While the file is being closed a) he file remains locked in whatever mode it was locked in, and b) it's file handle is not reassigned. Once the final response is sent, the lock is dropped and the handle is available for reassignment. Any attempt to issue any operation against a file being closed will return a \"file not open\" error. I should have this committed in a week or so after some more testing."}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/734#issuecomment-395853595"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] [XrdCl] Add an API to close connection. (#734)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 734,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 734\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/734#issuecomment-395853595"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 343900279\n}"
}
],
"themeColor": "26292E"
}
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1