 |
 |
Speaking of ENOTSUP for check sums. I thought the patch was OK but now I'm not sure. ENOTSUP is returned if the checksum algorithm is not supported as well. So, the patch would have the unintended effect of running into the checksum calculation code where the results will be undefined given that client may have wanted checksum x and the code may compute something but it won't be x (it may not even do anything reasonable at that point). If the system doesn't support extended attributes then XRootD should be configured to compute local check sums. You would need to supply a script to do so and then this problem wouldn't exist. So, I don't understand what problem is being solved here that couldn't have been solved with the right configuration. So, I can't endorse the change to XrdXrootdXeq.cc at this point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/769#issuecomment-406760943 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1