 |
 |
@bbockelm : I would say that the macaroon plug-in should only be built if libmacaroons is present. This will shield us from failures on platforms where libmacaroons is not available. Of course then the spec file needs to be tweaked so the plug-in gets only packaged for EPEL-7 and Fedora platforms (my understanding is that there is no libmacaroons for EPEL-6). The idea is that our build script will install the dependencies with yum-builddep / dnf builddep, and cmake will only build the plug-in if respective dependencies are in place. BTW Could you rewrite the history so there are fewer but more meaningful commits in the PR, ideally one called something like _Macaroons plugin for Xrootd_ ;-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/762#issuecomment-405251637 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1