Hi Brian, this is a nice one. I checked carefully and it seems fine to me. Now I'll compile for all the platforms and do some tests.
I would add this code to line 2399:
m_req_digest.clear();
m_resource_with_digest = "";
just because it's better to have clean variables across requests, it can ease debugging. Would you mind to add it?
Instead I can't fully understand the modification to XrdXrootdXeq. Even if it's tiny I'd prefer Andy to have a look at it. Basically you are not treating ENOTSUP as an error, which seems strange to me. Andy?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ffurano in #769: Hi Brian, this is a nice one. I checked carefully and it seems fine to me. Now I'll compile for all the platforms and do some tests.\r\nI would add this code to line 2399:\r\n m_req_digest.clear();\r\n m_resource_with_digest = \"\";\r\njust because it's better to have clean variables across requests, it can ease debugging. Would you mind to add it?\r\n\r\nInstead I can't fully understand the modification to XrdXrootdXeq. Even if it's tiny I'd prefer Andy to have a look at it. Basically you are not treating ENOTSUP as an error, which seems strange to me. Andy?"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/769#issuecomment-406273484"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406273484",
"url": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406273484",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] [XrdHTTP] Implement RFC3230 for providing resource digest (#769)",
"sections": [
{
"text": "",
"activityTitle": "**Fabrizio Furano**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ffurano",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 769,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 769\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406273484"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 357396191\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1