I should add that in the local computation, the default checksum manager can return success (i.e. everything is just fine) but the checksum has not been recorded (line 439). If that is the case, we automatically default to an external script if one has been supplied. This takes care of the case where sites want to compute check sums using a offline process and may or may not wish to have users force a real-time checksum. Let's just say the site requirements were pretty onerous here and that's why the code allows a wide range of options. Now that I further considered this (over a nice French meal) I really think the proposed patch to XrdXrootdXeq.cc should be removed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #769: I should add that in the local computation, the default checksum manager can return success (i.e. everything is just fine) but the checksum has not been recorded (line 439). If that is the case, we automatically default to an external script if one has been supplied. This takes care of the case where sites want to compute check sums using a offline process and may or may not wish to have users force a real-time checksum. Let's just say the site requirements were pretty onerous here and that's why the code allows a wide range of options. Now that I further considered this (over a nice French meal) I really think the proposed patch to XrdXrootdXeq.cc should be removed."}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/769#issuecomment-406771083"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406771083",
"url": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406771083",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] [XrdHTTP] Implement RFC3230 for providing resource digest (#769)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 769,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 769\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/769#issuecomment-406771083"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 357396191\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
