Hi @abh3 -
The description of the problem is in ticket #777, no?
Without this, the code path that calls ofs.ckslib invokes Config->GetRest twice, meaning that ofs.ckslib is consuming two lines of configuration.
For example, the following config snippet will fail to parse:
ofs.ckslib * /var/lib/xrootd-hdfs/lib/libXrdHdfs.so
if exec xrootd
fi
because the handling of ofs.ckslib will also consume the tokens if exec xrootd, meaning that Xrootd complains of an unmatched fi.
Brian
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm in #778: Hi @abh3 -\r\n\r\nThe description of the problem is in ticket #777, no?\r\n\r\nWithout this, the code path that calls `ofs.ckslib` invokes `Config-\u003eGetRest` twice, meaning that `ofs.ckslib` is consuming two lines of configuration.\r\n\r\nFor example, the following config snippet will fail to parse:\r\n\r\n```\r\nofs.ckslib * /var/lib/xrootd-hdfs/lib/libXrdHdfs.so\r\nif exec xrootd\r\nfi\r\n```\r\n\r\nbecause the handling of `ofs.ckslib` will also consume the tokens `if exec xrootd`, meaning that Xrootd complains of an unmatched `fi`.\r\n\r\nBrian"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/778#issuecomment-408870245"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/778#issuecomment-408870245",
"url": "https://github.com/xrootd/xrootd/pull/778#issuecomment-408870245",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] Prevent double-parsing of parameters for ofs.ckslib. (#778)",
"sections": [
{
"text": "",
"activityTitle": "**Brian Bockelman**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bbockelm",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 778,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 778\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/778#issuecomment-408870245"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 360919925\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1