@bbockelm : I would say that the macaroon plug-in should only be built if libmacaroons is present. This will shield us from failures on platforms where libmacaroons is not available. Of course then the spec file needs to be tweaked so the plug-in gets only packaged for EPEL-7 and Fedora platforms (my understanding is that there is no libmacaroons for EPEL-6).
The idea is that our build script will install the dependencies with yum-builddep / dnf builddep, and cmake will only build the plug-in if respective dependencies are in place.
BTW Could you rewrite the history so there are fewer but more meaningful commits in the PR, ideally one called something like Macaroons plugin for Xrootd ;-)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonmichal in #762: @bbockelm : I would say that the macaroon plug-in should only be built if libmacaroons is present. This will shield us from failures on platforms where libmacaroons is not available. Of course then the spec file needs to be tweaked so the plug-in gets only packaged for EPEL-7 and Fedora platforms (my understanding is that there is no libmacaroons for EPEL-6). \r\n\r\nThe idea is that our build script will install the dependencies with yum-builddep / dnf builddep, and cmake will only build the plug-in if respective dependencies are in place.\r\n\r\nBTW Could you rewrite the history so there are fewer but more meaningful commits in the PR, ideally one called something like _Macaroons plugin for Xrootd_ ;-)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/762#issuecomment-405251637"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/762#issuecomment-405251637",
"url": "https://github.com/xrootd/xrootd/pull/762#issuecomment-405251637",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] Macaroons plugin for Xrootd (#762)",
"sections": [
{
"text": "",
"activityTitle": "**simonmichal**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@simonmichal",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 762,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 762\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/762#issuecomment-405251637"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 354656096\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1