OK, I'm found the edge case that causes this problem. The patch I will be posting should cleanup in the case of a communications failure. The interaction with Stop() is still somewhat in the air but, in general, you need not call it after a communications error occurs, assuming you wish to continue using the service at the end-point. In other words, calling ProcessRequest() after a failure will simply queue the requests until the server comes back up. All requests prior to the failure will be cleaned up and the original resource will be made non-reusable. In theory, you need not special case this particular error. That said, we shall know when this occurs in practice (my test show it works as expected).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #775: OK, I'm found the edge case that causes this problem. The patch I will be posting should cleanup in the case of a communications failure. The interaction with Stop() is still somewhat in the air but, in general, you need not call it after a communications error occurs, assuming you wish to continue using the service at the end-point. In other words, calling ProcessRequest() after a failure will simply queue the requests until the server comes back up. All requests prior to the failure will be cleaned up and the original resource will be made non-reusable. In theory, you need not special case this particular error. That said, we shall know when this occurs in practice (my test show it works as expected). "}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/775#issuecomment-415329031"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/775#issuecomment-415329031",
"url": "https://github.com/xrootd/xrootd/issues/775#issuecomment-415329031",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] [SSI] Memory leak when client loses connection to server (#775)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 775,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 775\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/775#issuecomment-415329031"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 360700809\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
