Hi Vladimir.
On Wed, 1 Aug 2018, Vladimir Lomov wrote:
>> on an RH build it works as expected (i.e. no references to these)
>
> thanks for checking. Could you give a bit more details: do you use
cmake, do you use the distribution tools for packaging (I don't know how
RPM packages are created, of course, not "manually"), version of tools:
gcc, cmake, glibc?
We use a standard RPM script to build the RPM. You can find it in
xrootd/packaging/makesrpm.sh
it is driven off gthe particular platform in question as you will see in
the enclosing directory. There is nothing magical about it. All the
standad toold you mentioned are used. Be aware that when cmake creates
artifacts in the "src" directory, it also sets runpath and a few other
references so that you can run he executabes in he "src" directory and be
sure you are not referencing anthing out side ot it. These get stripped
off when you build an RPM and we strip them off manually for other kinds
of builds. So, perhaps, you are concerned with the stuff in the "src"
build of cmake. The non-essential refernces are supposed to be
eliminated when a actual distribution package is created.
> I suspect this might be due to cmake (I opened issue for xxHash program
with the same question and the author replied that it is ok with make).
Yes, I suspect that is what the case is here.
>> That aside, why is this causing a problem?
>
> First: it is useless. Secondly, I don't understand how these paths are
passed to the binaries, so I not sure what consequences it can cause.
The are not supposed to be. The paths are forced by cmake to make sure
that when you run something out of the cmake artifact directory (i.e.
"src") you only reference things that are relevant to the build. When you
create the distribution package, all of that stuff is stripped out so no
side-effects should remain.
Andy
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #790: Hi Vladimir.\n\nOn Wed, 1 Aug 2018, Vladimir Lomov wrote:\n\n\u003e\u003e on an RH build it works as expected (i.e. no references to these)\n\u003e\n\u003e thanks for checking. Could you give a bit more details: do you use \ncmake, do you use the distribution tools for packaging (I don't know how \nRPM packages are created, of course, not \"manually\"), version of tools: \ngcc, cmake, glibc?\nWe use a standard RPM script to build the RPM. You can find it in\n\nxrootd/packaging/makesrpm.sh\n\nit is driven off gthe particular platform in question as you will see in \nthe enclosing directory. There is nothing magical about it. All the \nstandad toold you mentioned are used. Be aware that when cmake creates \nartifacts in the \"src\" directory, it also sets runpath and a few other \nreferences so that you can run he executabes in he \"src\" directory and be \nsure you are not referencing anthing out side ot it. These get stripped \noff when you build an RPM and we strip them off manually for other kinds \nof builds. So, perhaps, you are concerned with the stuff in the \"src\" \nbuild of cmake. The non-essential refernces are supposed to be \neliminated when a actual distribution package is created.\n\n\u003e I suspect this might be due to cmake (I opened issue for xxHash program \nwith the same question and the author replied that it is ok with make).\nYes, I suspect that is what the case is here.\n\u003e\u003e That aside, why is this causing a problem?\n\u003e\n\u003e First: it is useless. Secondly, I don't understand how these paths are \npassed to the binaries, so I not sure what consequences it can cause.\nThe are not supposed to be. The paths are forced by cmake to make sure \nthat when you run something out of the cmake artifact directory (i.e. \n\"src\") you only reference things that are relevant to the build. When you \ncreate the distribution package, all of that stuff is stripped out so no \nside-effects should remain.\n\nAndy\n"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/790#issuecomment-409852974"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/790#issuecomment-409852974",
"url": "https://github.com/xrootd/xrootd/issues/790#issuecomment-409852974",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] libXrdCryptossl-4.so has references to build directory, how to get rid of them? (#790)",
"sections": [
{
"text": "",
"activityTitle": "**Andrew Hanushevsky**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@abh3",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 790,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 790\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/790#issuecomment-409852974"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 363396870\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
