Hello,
I tried to compile the ```xrootd``` project with ```NODEBUG``` macro set and it failed. A quick look at the errors tells me that some code was written as if ```NODEBUG``` is always unset. Then what is the purpose of this macro and all the logic with it?
Some errors:
- from GCC (very intolerant to some code styles):
```
tmp/xrootd-4.8.4/src/XrdSut/XrdSutAux.cc: In function ‘const char* XrdSutHome()’:
tmp/xrootd-4.8.4/src/XrdSut/XrdSutAux.cc:474:54: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body]
DEBUG("Warning: home directory undefined! ");
^
cc1plus: all warnings being treated as errors
...
```
- from CLANG:
```
/home/vladimir/tmp/xrootd-4.8.4/src/XrdOfs/XrdOfs.cc:217:22: error: use of undeclared identifier 'epname'
XrdOfsFS->Emsg(epname, error, EADDRINUSE, "open directory", dir_path);
^
/home/vladimir/tmp/xrootd-4.8.4/src/XrdOfs/XrdOfs.cc:221:4: error: use of undeclared identifier 'epname'
AUTHORIZE(client,&Open_Env,AOP_Readdir,"open directory",dir_path,error);
...
```
P.S. I found this while I was researching Issue #790 .
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/issues/794
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
