Hello,
I tried to compile the xrootd project with NODEBUG macro set and it failed. A quick look at the errors tells me that some code was written as if NODEBUG is always unset. Then what is the purpose of this macro and all the logic with it?

Some errors:

tmp/xrootd-4.8.4/src/XrdSut/XrdSutAux.cc: In function ‘const char* XrdSutHome()’:                                                                                  
tmp/xrootd-4.8.4/src/XrdSut/XrdSutAux.cc:474:54: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body]                                 
          DEBUG("Warning: home directory undefined! ");                                                                                                                           
                                                      ^                                                                                                                           
cc1plus: all warnings being treated as errors
...

/home/vladimir/tmp/xrootd-4.8.4/src/XrdOfs/XrdOfs.cc:217:22: error: use of undeclared identifier 'epname'                                                                         
      XrdOfsFS->Emsg(epname, error, EADDRINUSE, "open directory", dir_path);                                                                                                      
                     ^                                                                                                                                                            
/home/vladimir/tmp/xrootd-4.8.4/src/XrdOfs/XrdOfs.cc:221:4: error: use of undeclared identifier 'epname'                                                                          
   AUTHORIZE(client,&Open_Env,AOP_Readdir,"open directory",dir_path,error);
...

P.S. I found this while I was researching Issue #790 .

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Purpose of NODEBUG macro and whole logic with it (#794)"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/794"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/issues/794", "url": "https://github.com/xrootd/xrootd/issues/794", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Purpose of NODEBUG macro and whole logic with it (#794)", "sections": [ { "text": "", "activityTitle": "**Vladimir Lomov**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@vp1981", "facts": [ { "name": "Repository: ", "value": "xrootd/xrootd" }, { "name": "Issue #: ", "value": 794 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 794,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 794\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/xrootd/xrootd/issues/794" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 365766151\n}" } ], "themeColor": "26292E" } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1