Print

Print


  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 88dad6ab1a1062749ba5e9ca5e0e9b98acbcddab
      https://github.com/xrootd/xrootd/commit/88dad6ab1a1062749ba5e9ca5e0e9b98acbcddab
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/XrdHttp/XrdHttpProtocol.cc

  Log Message:
  -----------
  Do not increment reqstate when headers are incomplete.

If the server got incomplete headers (I was able to reliably trigger
this with connection reuse), the reqstate variable was still incremented.

This resulted in the request state becoming inconsistent - notably,
HEAD requests believed they always included a checksum.  There are
likely other strange XrdHttp behaviors that could have been triggered
due to the same bug.


  Commit: fbd3861df939d4c451b23b43a7d924c427f64da2
      https://github.com/xrootd/xrootd/commit/fbd3861df939d4c451b23b43a7d924c427f64da2
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/XrdHttp/XrdHttpReq.cc

  Log Message:
  -----------
  Apply correct test for strcasecmp return value.

We were applying the wrong test to strcasecmp's return value, resulting
in the server often (incorrectly) assuming that we were supposed to
compute the SHA1 checksum.


  Commit: 7407ea85efba9c116e4d42156fc835f8c51b569d
      https://github.com/xrootd/xrootd/commit/7407ea85efba9c116e4d42156fc835f8c51b569d
  Author: Fabrizio Furano <[log in to unmask]>
  Date:   2018-09-11 (Tue, 11 Sep 2018)

  Changed paths:
    M src/XrdHttp/XrdHttpProtocol.cc
    M src/XrdHttp/XrdHttpReq.cc

  Log Message:
  -----------
  Merge pull request #822 from bbockelm/checksum_headers

Fixes for XrdHttp request state issues


Compare: https://github.com/xrootd/xrootd/compare/a04e2c67bf32...7407ea85efba
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1