If the server got incomplete headers (I was able to reliably trigger this with connection reuse), the `reqstate` variable was still incremented.
This resulted in the request state becoming inconsistent - notably, for master, we saw `HEAD` requests believed they always included a checksum. There are likely other strange XrdHttp behaviors that could have been triggered due to the same bug, hence the request for backport to the stable branch.
(cherry picked from commit 88dad6ab1a1062749ba5e9ca5e0e9b98acbcddab; backport of relevant fix in #822)
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/825
-- Commit Summary --
* Do not increment reqstate when headers are incomplete.
-- File Changes --
M src/XrdHttp/XrdHttpProtocol.cc (1)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/825.patch
https://github.com/xrootd/xrootd/pull/825.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/825
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
