Hi Andy,
I don't really understand your comment about backwards compatibility. kXR_mkpath is defined as 256 (defn). However, the options field of the kXR_mkdir command is only 8-bit wide, so cannot hold this flag.
In fact, the SLAC xrootd implementation uses the undocumented kXR_mkdirpath flag (defn).
As for dCache, you should follow the spec not the implementation.
That is, indeed, our goal.
Our problem is that the SLAC xrootd does not follow the xrootd specification and we have users that depend on dCache behaving like SLAC xrood implementation.
My proposed solution is simple: update the documentation to accurately describe the SLAC xrootd software behaviour. This simply means changing the label kXR_mkpath to kXR_mkdirpath when describing the kXR_mkdir command.
Do you have an estimate when the protocol document will be updated?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@paulmillar in #815: Hi Andy,\r\n\r\nI don't really understand your comment about backwards compatibility. `kXR_mkpath` is defined as `256` ([defn](https://github.com/xrootd/xrootd/blob/master/src/XProtocol/XProtocol.hh#L222)). However, the `options` field of the `kXR_mkdir` command is only 8-bit wide, so cannot hold this flag. \r\n\r\nIn fact, the SLAC xrootd implementation uses the undocumented `kXR_mkdirpath` flag ([defn](https://github.com/xrootd/xrootd/blob/master/src/XProtocol/XProtocol.hh#L161)).\r\n\r\n\u003e As for dCache, you should follow the spec not the implementation.\r\n\r\nThat is, indeed, our goal.\r\n\r\nOur problem is that the SLAC xrootd does not follow the xrootd specification and we have users that depend on dCache behaving like SLAC xrood implementation.\r\n\r\nMy proposed solution is simple: update the documentation to accurately describe the SLAC xrootd software behaviour. This simply means changing the label `kXR_mkpath` to `kXR_mkdirpath` when describing the `kXR_mkdir` command.\r\n\r\nDo you have an estimate when the protocol document will be updated?"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/815#issuecomment-420962527"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/815#issuecomment-420962527",
"url": "https://github.com/xrootd/xrootd/issues/815#issuecomment-420962527",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] kXR_mkdir does not accept kXR_mkpath in options field. (#815)",
"sections": [
{
"text": "",
"activityTitle": "**Paul Millar**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@paulmillar",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 815,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 815\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/815#issuecomment-420962527"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 376220652\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1