Are you saying that the specification is correct, and the same numerical value (kXR_mkpath) should be used in both kXR_mkdir and kXR_open commands?
If so, fixing this in SLAC xrootd would require a non-backwards compatible change in SLAC xrootd software.
However, this breaking backwards incompatibility is simply not needed.
There is no reason the same semantics must be represented by the same numerical value in different operations. The current SLAC xrootd behaviour is perfectly reasonable: using 0x01 in kXR_mkdir and 0x100 in kXR_open to indicate paths should be created automatically.
Therefore, my proposal to fix this (update documentation, changing the kXR_mkdir command's constant from kXR_mkpath to kXR_mkdirpath) will resolve this issue without requiring any changes in SLAC xrootd and without breaking backwards compatibility.
This solution treats the problem as a simple typo in the specification. Fixing it is equally easy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@paulmillar in #815: Are you saying that the specification is correct, and the same numerical value (`kXR_mkpath`) should be used in both `kXR_mkdir` and `kXR_open` commands?\r\n\r\nIf so, fixing this in SLAC xrootd would require a non-backwards compatible change in SLAC xrootd software.\r\n\r\nHowever, this breaking backwards incompatibility is simply not needed.\r\n\r\nThere is no reason the same semantics must be represented by the same numerical value in different operations. The current SLAC xrootd behaviour is perfectly reasonable: using 0x01 in `kXR_mkdir` and 0x100 in `kXR_open` to indicate paths should be created automatically.\r\n\r\nTherefore, my proposal to fix this (update documentation, changing the `kXR_mkdir` command's constant from `kXR_mkpath` to `kXR_mkdirpath`) will resolve this issue without requiring any changes in SLAC xrootd and without breaking backwards compatibility.\r\n\r\nThis solution treats the problem as a simple typo in the specification. Fixing it is equally easy."}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/815#issuecomment-421287642"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/815#issuecomment-421287642",
"url": "https://github.com/xrootd/xrootd/issues/815#issuecomment-421287642",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] kXR_mkdir does not accept kXR_mkpath in options field. (#815)",
"sections": [
{
"text": "",
"activityTitle": "**Paul Millar**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@paulmillar",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 815,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 815\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/815#issuecomment-421287642"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 376220652\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
