I could put something like:
#pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Werror" memset(xxx, 255, GetSizeInBytes()); /* no diagnostic for this one */ #pragma GCC diagnostic pop
or add comment like:
// The following should be: memset(m_store.m_buff_synced, 255, GetSizeInBytes()); // but GCC produces an overzealous 'possible argument transpose warning' and // xrootd build uses warnings->errors escalation. // See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61294
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@osschar in #826: I could put something like:\r\n`\r\n#pragma GCC diagnostic push\r\n#pragma GCC diagnostic ignored \"-Werror\"\r\n memset(xxx, 255, GetSizeInBytes()); /* no diagnostic for this one */\r\n#pragma GCC diagnostic pop\r\n`\r\nor add comment like:\r\n`\r\n // The following should be: memset(m_store.m_buff_synced, 255, GetSizeInBytes());\r\n // but GCC produces an overzealous 'possible argument transpose warning' and\r\n // xrootd build uses warnings-\u003eerrors escalation.\r\n // See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61294\r\n`"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/826#issuecomment-422085391"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/826#issuecomment-422085391",
"url": "https://github.com/xrootd/xrootd/pull/826#issuecomment-422085391",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] Pfc purge v2 (#826)",
"sections": [
{
"text": "",
"activityTitle": "**Matevž Tadel**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@osschar",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 826,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"pullRequestId\": 826\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/pull/826#issuecomment-422085391"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380454600\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
