Hi Andy,
Thanks for the comments, although I think you misunderstood the focus of this issue.
I'm referring to the PROTOCOL DOCUMENTATION, not about any client implementation or server implementation (i.e., this is NOT about code).
In v2.9.9 (linked to above) the PROTOCOL DOCUMENTATION does not describe what fhandle means, when describing the kXR_stat request. The field appears in the request structure, but is not described in the Where: section.
The same problem exists in the v3.1.0 and v4.0.0 of the PROTOCOL DOCUMENTATION: none of these versions describe what fhandle means for the kXR_stat request.
From reading the xrootd source code, I believe fhandle is an opened file handle (as returned by kXR_open). Also, if the client makes an kXR_stat request and specifies the plen value of zero then the server should use the fhandle value; otherwise, the path information (plen / path) is used.
It would be helpful if these details where checked, and the PROTOCOL DOCUMENTATION is updated to record this information, if they are correct.
Cheers,
Paul.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@paulmillar in #839: Hi Andy,\r\n\r\nThanks for the comments, although I think you misunderstood the focus of this issue.\r\n\r\nI'm referring to the PROTOCOL DOCUMENTATION, not about any client implementation or server implementation (i.e., this is NOT about code).\r\n\r\nIn v2.9.9 (linked to above) the PROTOCOL DOCUMENTATION does not describe what `fhandle` means, when describing the `kXR_stat` request. The field appears in the request structure, but is not described in the `Where:` section.\r\n\r\nThe same problem exists in the [v3.1.0](http://xrootd.org/doc/dev45/XRdv310.htm#_Toc464248850) and [v4.0.0](http://xrootd.org/doc/dev49/XRdv400.htm#_Toc517297887) of the PROTOCOL DOCUMENTATION: none of these versions describe what `fhandle` means for the `kXR_stat` request.\r\n\r\nFrom reading the xrootd source code, I believe `fhandle` is an opened file handle (as returned by kXR_open). Also, if the client makes an kXR_stat request and specifies the `plen` value of zero then the server should use the `fhandle` value; otherwise, the path information (`plen` / `path`) is used.\r\n\r\nIt would be helpful if these details where checked, and the PROTOCOL DOCUMENTATION is updated to record this information, if they are correct.\r\n\r\nCheers,\r\n\r\nPaul."}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/839#issuecomment-428683173"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/839#issuecomment-428683173",
"url": "https://github.com/xrootd/xrootd/issues/839#issuecomment-428683173",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [xrootd/xrootd] [protocol specification] kXR_stat#fhandle is undocumented (#839)",
"sections": [
{
"text": "",
"activityTitle": "**Paul Millar**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@paulmillar",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 839,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 839\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/xrootd/xrootd/issues/839#issuecomment-428683173"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 391533377\n}"
}
],
"themeColor": "26292E"
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1