Hi Chris,

could you generate a pull request for this? Would it be possible to special case this so that your fix only applies to older version of MacOS and newer version use the current code.

Andy

From: Chris Jones
Sent: Tuesday, October 23, 2018 5:57 AM
To: xrootd/xrootd
Cc: Subscribed
Subject: Re: [xrootd/xrootd] v4.8.5 - Compilation failure on OSX10.11 and older due to CLOCK_REALTIME (#846)

FWIW, the workaround I am now using can be seen here.

cjones051073@b2f0459

I have validated with a little test application the two methods give consistent results. e.g.

> clang++ ./time.cpp
> ./a.out
time1 1540296079731436000
time2 1540296079731497000
time1 1540296079731516000
time2 1540296079731526000
ā€”
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #846: Hi Chris,\n\ncould you generate a pull request for this? Would it be possible to special case this so that your fix only applies to older version of MacOS and newer version use the current code.\n\nAndy\n\nFrom: Chris Jones \nSent: Tuesday, October 23, 2018 5:57 AM\nTo: xrootd/xrootd \nCc: Subscribed \nSubject: Re: [xrootd/xrootd] v4.8.5 - Compilation failure on OSX10.11 and older due to CLOCK_REALTIME (#846)\n\nFWIW, the workaround I am now using can be seen here.\n\ncjones051073@b2f0459\n\nI have validated with a little test application the two methods give consistent results. e.g.\n\n \u003e clang++ ./time.cpp\n \u003e ./a.out \ntime1 1540296079731436000\ntime2 1540296079731497000\ntime1 1540296079731516000\ntime2 1540296079731526000\nā€”\nYou are receiving this because you are subscribed to this thread.\nReply to this email directly, view it on GitHub, or mute the thread.\n"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/846#issuecomment-432415914"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/issues/846#issuecomment-432415914", "url": "https://github.com/xrootd/xrootd/issues/846#issuecomment-432415914", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [xrootd/xrootd] v4.8.5 - Compilation failure on OSX10.11 and older due to CLOCK_REALTIME (#846)", "sections": [ { "text": "", "activityTitle": "**Andrew Hanushevsky**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@abh3", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 846,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"xrootd/xrootd\",\n\"issueId\": 846\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/xrootd/xrootd/issues/846#issuecomment-432415914" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 399583199\n}" } ], "themeColor": "26292E" } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1