Print

---

bbockelm requested changes on this pull request.

Small changes requested to match coding conventions (should be able to merge them via the GitHub UI).

As a bigger picture issue though, this breaks the ABI for external handlers (I confirmed plugins built against 4.8.x crash with this applied).

I think this is OK -- it's in the `xrootd/private` header namespace -- but we should bump the minimum API version for external handlers in order to have server refuse to start instead of crashing.

I'm not sure I know how to do that.  @abh3 - do you?

> @@ -67,6 +68,9 @@ XrdHttpExtReq::XrdHttpExtReq(XrdHttpReq *req, XrdHttpProtocol *pr): prot(pr),
 verb(req->requestverb), headers(req->allheaders) {
   // Here we fill the request summary with all the fields we can
   resource = req->resource.c_str();
+  int envlen=0;
+  
+  query = req->opaque?req->opaque->Env(envlen):"";

```suggestion
  query = req->opaque ? req->opaque->Env(envlen) : "";
```

> @@ -67,6 +68,9 @@ XrdHttpExtReq::XrdHttpExtReq(XrdHttpReq *req, XrdHttpProtocol *pr): prot(pr),
 verb(req->requestverb), headers(req->allheaders) {
   // Here we fill the request summary with all the fields we can
   resource = req->resource.c_str();
+  int envlen=0;

```suggestion
  int envlen = 0;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/879#pullrequestreview-184885394

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1