Print

Print

@bbockelm requested changes on this pull request.

Small changes requested to match coding conventions (should be able to merge them via the GitHub UI).

As a bigger picture issue though, this breaks the ABI for external handlers (I confirmed plugins built against 4.8.x crash with this applied).

I think this is OK -- it's in the xrootd/private header namespace -- but we should bump the minimum API version for external handlers in order to have server refuse to start instead of crashing.

I'm not sure I know how to do that. @abh3 - do you?

In src/XrdHttp/XrdHttpExtHandler.cc:

> @@ -67,6 +68,9 @@ XrdHttpExtReq::XrdHttpExtReq(XrdHttpReq *req, XrdHttpProtocol *pr): prot(pr),
 verb(req->requestverb), headers(req->allheaders) {
   // Here we fill the request summary with all the fields we can
   resource = req->resource.c_str();
+  int envlen=0;
+  
+  query = req->opaque?req->opaque->Env(envlen):"";
⬇️ Suggested change 
-  query = req->opaque?req->opaque->Env(envlen):"";
+  query = req->opaque ? req->opaque->Env(envlen) : "";

In src/XrdHttp/XrdHttpExtHandler.cc:

> @@ -67,6 +68,9 @@ XrdHttpExtReq::XrdHttpExtReq(XrdHttpReq *req, XrdHttpProtocol *pr): prot(pr),
 verb(req->requestverb), headers(req->allheaders) {
   // Here we fill the request summary with all the fields we can
   resource = req->resource.c_str();
+  int envlen=0;
⬇️ Suggested change 
-  int envlen=0;
+  int envlen = 0;

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm requested changes on #879"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/879#pullrequestreview-184885394"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/879#pullrequestreview-184885394", "url": "https://github.com/xrootd/xrootd/pull/879#pullrequestreview-184885394", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1